fix: added return on redirect#487
Merged
Merged
Conversation
WillFortMadeTech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is off the back of a container restart we had yesterday for Droits which is due to a "double response".
Throwing two responses to one request throws the error, and uncaught this kills the process.
property-form.js already had this return set up:
Therefore it seems like this is something that has been observed before, but the surface area for this error wasn't covered.
This has been tested locally. Testing currently in dev and providing all is working as expected we can move to staging and prod shortly.